Add beta_cdf and inverse_beta_cdf math functions.#11981
Add beta_cdf and inverse_beta_cdf math functions.#11981Vayu wants to merge 4 commits intoprestodb:masterfrom
Conversation
These are useful for calculating confidence intervals of Bernoulli trails. https://en.wikipedia.org/wiki/Binomial_proportion_confidence_interval#Jeffreys_interval
martint
left a comment
There was a problem hiding this comment.
The syntax looks good. It's consistent with the normal distribution variants.
Use BetaDistribution constructor with explicit RandomGenerator = null since we don't need it here.
|
@martint addressed comments |
|
clarified error messages |
|
@martint improved error messages, can we merge that too? |
I'll do that after the current release goes out. |
|
@mbasmanova @rschlussel @rongrong this PR got forgotten, it has improved error messages for beta_cdf and inverse_beta_cdf. Can we merge it? |
|
@Vayu Could you rebase to the top of master and resolve conflicts. I'll review and merge then. |
|
@Vayu I'm seeing 5 commits, but I think there should be only one or two. Please, squash commits. |
|
@Vayu, the final diff looks wrong. It only includes error message improvements, but doesn't show any new functions. Would you double check? |
|
@Vayu you might want to rebase your changes on top of the current master, rather than doing a merge. Please merge all your changes to 1 single commit. You can do |
|
@Vayu ping |
|
@mbasmanova the final diff has only error messages because everything before that is already merged into release branch, so the merge should only pick the last commit. Do you still want me to rebase and squash though? |
|
@Vayu, understood. Please, rebase, squash commits if there will be more than one left and review the commit message to make sure it accurately reflects the changes. |
|
@Vayu Valery, are you still interested in merging this PR? If so, would you rebase, resolve conflicts and squash commits? |
9c4f74c to
cc00e93
Compare
|
moved follow-up to #12621 |
These are useful for calculating confidence intervals of Bernoulli trails.
https://en.wikipedia.org/wiki/Binomial_proportion_confidence_interval#Jeffreys_interval